From c8003a8ae88a3ee95f802db1527964b92fa794c4 Mon Sep 17 00:00:00 2001 From: silentrald Date: Sat, 19 Oct 2024 00:27:27 +0800 Subject: [PATCH 1/5] [bugfix] proper filter for leaderboard/ranking * use leaderboard query param with beatsaver * fixed issue where blRanked is not showing on mapItem components --- assets/jsons/translations/de.json | 9 +++++- assets/jsons/translations/en.json | 9 +++++- assets/jsons/translations/es.json | 9 +++++- assets/jsons/translations/fr.json | 9 +++++- assets/jsons/translations/ja.json | 9 +++++- assets/jsons/translations/ru.json | 9 +++++- assets/jsons/translations/zh-tw.json | 9 +++++- assets/jsons/translations/zh.json | 9 +++++- .../beat-saver/beat-saver-api.service.ts | 6 +++- .../maps/filter-panel.component.tsx | 31 +++++++++++++++---- src/shared/models/maps/beat-saver.model.ts | 9 ++++-- 11 files changed, 101 insertions(+), 17 deletions(-) diff --git a/assets/jsons/translations/de.json b/assets/jsons/translations/de.json index d280acd0..f189ba08 100644 --- a/assets/jsons/translations/de.json +++ b/assets/jsons/translations/de.json @@ -832,7 +832,8 @@ "tags": "Stichwörter", "specificities": "Allgemein", "requirements": "Anforderungen", - "exclude": "Ausschließen" + "exclude": "Ausschließen", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "Präzision", @@ -888,6 +889,12 @@ "verified": "Verifiziert", "fullSpread": "Full Spread" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "Installiert" }, diff --git a/assets/jsons/translations/en.json b/assets/jsons/translations/en.json index 6bf60e2f..c9b679a5 100644 --- a/assets/jsons/translations/en.json +++ b/assets/jsons/translations/en.json @@ -839,7 +839,8 @@ "tags": "tags", "specificities": "general", "requirements": "requirements", - "exclude": "exclude" + "exclude": "exclude", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "accuracy", @@ -895,6 +896,12 @@ "verified": "verified", "fullSpread": "full spread" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "installed" }, diff --git a/assets/jsons/translations/es.json b/assets/jsons/translations/es.json index 0ea57cbb..908aa321 100644 --- a/assets/jsons/translations/es.json +++ b/assets/jsons/translations/es.json @@ -832,7 +832,8 @@ "tags": "tags", "specificities": "general", "requirements": "requisitos", - "exclude": "excluir" + "exclude": "excluir", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "precisión", @@ -888,6 +889,12 @@ "verified": "verificado", "fullSpread": "panel completo" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "instalado" }, diff --git a/assets/jsons/translations/fr.json b/assets/jsons/translations/fr.json index 0695a01a..1f7b7103 100644 --- a/assets/jsons/translations/fr.json +++ b/assets/jsons/translations/fr.json @@ -833,7 +833,8 @@ "tags": "tags", "specificities": "général", "requirements": "requis", - "exclude": "exclure" + "exclude": "exclure", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "précision", @@ -889,6 +890,12 @@ "verified": "vérifiée", "fullSpread": "panel complet" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "installé" }, diff --git a/assets/jsons/translations/ja.json b/assets/jsons/translations/ja.json index eb259009..b1209ad2 100644 --- a/assets/jsons/translations/ja.json +++ b/assets/jsons/translations/ja.json @@ -832,7 +832,8 @@ "tags": "タグ", "specificities": "一般", "requirements": "要Mod", - "exclude": "除外する" + "exclude": "除外する", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "正確", @@ -888,6 +889,12 @@ "verified": "認証済み", "fullSpread": "フルスプレッド" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "インストール済み" }, diff --git a/assets/jsons/translations/ru.json b/assets/jsons/translations/ru.json index 7e4c1a13..be1bcba6 100644 --- a/assets/jsons/translations/ru.json +++ b/assets/jsons/translations/ru.json @@ -831,7 +831,8 @@ "tags": "тэги", "specificities": "основное", "requirements": "требуемые моды", - "exclude": "исключить" + "exclude": "исключить", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "точность", @@ -887,6 +888,12 @@ "verified": "проверенные авторы", "fullSpread": "полный набор" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "установленный" }, diff --git a/assets/jsons/translations/zh-tw.json b/assets/jsons/translations/zh-tw.json index 598bd6f1..37aaeace 100644 --- a/assets/jsons/translations/zh-tw.json +++ b/assets/jsons/translations/zh-tw.json @@ -832,7 +832,8 @@ "tags": "標籤", "specificities": "general", "requirements": "要求", - "exclude": "排除" + "exclude": "排除", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "精確度", @@ -888,6 +889,12 @@ "verified": "Verified", "fullSpread": "Full spread" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "已安裝" }, diff --git a/assets/jsons/translations/zh.json b/assets/jsons/translations/zh.json index 3e0f263b..b7f2624d 100644 --- a/assets/jsons/translations/zh.json +++ b/assets/jsons/translations/zh.json @@ -832,7 +832,8 @@ "tags": "标签", "specificities": "general", "requirements": "要求", - "exclude": "排除" + "exclude": "排除", + "leaderboard": "leaderboard" }, "map-types": { "accuracy": "精确度", @@ -888,6 +889,12 @@ "verified": "verified", "fullSpread": "full spread" }, + "map-leaderboard": { + "All": "All", + "Ranked": "Ranked", + "BeatLeader": "BeatLeader", + "ScoreSaber": "ScoreSaber" + }, "map-excludes": { "installed": "已安装" }, diff --git a/src/main/services/thrid-party/beat-saver/beat-saver-api.service.ts b/src/main/services/thrid-party/beat-saver/beat-saver-api.service.ts index 8ccb2eed..75b911d6 100644 --- a/src/main/services/thrid-party/beat-saver/beat-saver-api.service.ts +++ b/src/main/services/thrid-party/beat-saver/beat-saver-api.service.ts @@ -1,5 +1,5 @@ import { BsvMapDetail } from "shared/models/maps"; -import { BsvPlaylistPage, MapFilter, PlaylistSearchParams, PlaylistSearchResponse, SearchParams, SearchResponse } from "shared/models/maps/beat-saver.model"; +import { BsvPlaylistPage, MapFilter, MapLeaderboard, PlaylistSearchParams, PlaylistSearchResponse, SearchParams, SearchResponse } from "shared/models/maps/beat-saver.model"; import { RequestService } from "../../request.service"; import { CustomError } from "shared/models/exceptions/custom-error.class"; @@ -32,6 +32,10 @@ export class BeatSaverApiService { return new URLSearchParams(); } + if (!filter.leaderboard) { + filter.leaderboard = MapLeaderboard.All; + } + const enbledTagsString = filter.enabledTags ? Array.from(filter.enabledTags) : null; const excludedTagsString = filter.excludedTags ? Array.from(filter.excludedTags).map(tag => `!${tag}`) : null; diff --git a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx index 07a4fc3e..1917de54 100644 --- a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx +++ b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx @@ -1,4 +1,4 @@ -import { BsvMapDetail, MapFilter, MapRequirement, MapSpecificity, MapStyle, MapTag, MapType } from "shared/models/maps/beat-saver.model"; +import { BsvMapDetail, MapFilter, MapLeaderboard, MapRequirement, MapSpecificity, MapStyle, MapTag, MapType } from "shared/models/maps/beat-saver.model"; import { motion } from "framer-motion"; import { MutableRefObject, useEffect, useRef, useState } from "react"; import { BsmCheckbox } from "../../shared/bsm-checkbox.component"; @@ -14,6 +14,8 @@ import { BsmLocalMap } from "shared/models/maps/bsm-local-map.interface"; import { SongDetails } from "shared/models/maps"; import formatDuration from "format-duration"; import { MapInfo } from "shared/models/maps/info/map-info.model"; +import { BsmSelect, BsmSelectOption } from "renderer/components/shared/bsm-select.component"; +import { useConstant } from "renderer/hooks/use-constant.hook"; export type Props = { className?: string; @@ -45,6 +47,13 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat const isTagActivated = (tag: MapTag): boolean => filter?.enabledTags?.has(tag) || filter?.excludedTags?.has(tag); const isTagExcluded = (tag: MapTag): boolean => filter?.excludedTags?.has(tag); + const leaderboardOptions: BsmSelectOption[] = useConstant( + () => Object.values(MapLeaderboard).map(key => ({ + text: `maps.map-leaderboard.${key}`, + value: key, + })) + ); + useEffect(() => { if (firstRun.current) { firstRun.current = false; @@ -137,10 +146,6 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat return t(`maps.map-styles.${style}`); }; - const translateMapSpecificity = (specificity: MapSpecificity): string => { - return t(`maps.map-specificities.${specificity}`); - }; - type BooleanKeys = { [k in keyof T]: T[k] extends boolean ? k : never }[keyof T]; const handleCheckbox = (key: BooleanKeys) => { @@ -153,6 +158,12 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat onChange(newFilter); }; + const handleLeaderboardChange = (value: MapLeaderboard) => { + const newFilter = { ...(filter ?? {}) }; + newFilter.leaderboard = value; + onChange(newFilter); + } + const handleApply = () => { onApply(filter); setHaveChanged(() => false); @@ -173,9 +184,17 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat {Object.values(MapSpecificity).map(specificity => (
handleCheckbox(specificity)}> handleCheckbox(specificity)} /> - {translateMapSpecificity(specificity)} + {t(`maps.map-specificities.${specificity}`)}
))} + +

{t("maps.map-filter-panel.leaderboard")}

+ +

{t("maps.map-filter-panel.requirements")}

{Object.values(MapRequirement).map(requirement => (
handleCheckbox(requirement)}> diff --git a/src/shared/models/maps/beat-saver.model.ts b/src/shared/models/maps/beat-saver.model.ts index d8d2c1d2..5f1f2322 100644 --- a/src/shared/models/maps/beat-saver.model.ts +++ b/src/shared/models/maps/beat-saver.model.ts @@ -209,11 +209,16 @@ export enum MapRequirement { export enum MapSpecificity { Automapper = "automapper", - Ranked = "ranked", Curated = "curated", Verified = "verified", FullSpread = "fullSpread" +} +export enum MapLeaderboard { + All = "All", + Ranked = "Ranked", + BeatLeader = "BeatLeader", + ScoreSaber = "ScoreSaber", } // [ Admin, Uploader, SageScore, None ] @@ -235,7 +240,7 @@ export interface MapFilter { from?: number; to?: number; fullSpread?: boolean; - ranked?: boolean; + leaderboard?: string; installed?: boolean; minDuration?: number; maxDuration?: number; From 56976487f2aeef851cf58596c33fa258185d0e7b Mon Sep 17 00:00:00 2001 From: silentrald Date: Sat, 19 Oct 2024 00:42:28 +0800 Subject: [PATCH 2/5] [bugfix-623] add translations --- assets/jsons/translations/de.json | 6 +++--- assets/jsons/translations/es.json | 6 +++--- assets/jsons/translations/fr.json | 6 +++--- assets/jsons/translations/ja.json | 6 +++--- assets/jsons/translations/ru.json | 6 +++--- assets/jsons/translations/zh-tw.json | 6 +++--- assets/jsons/translations/zh.json | 6 +++--- 7 files changed, 21 insertions(+), 21 deletions(-) diff --git a/assets/jsons/translations/de.json b/assets/jsons/translations/de.json index f189ba08..f9b7cd5e 100644 --- a/assets/jsons/translations/de.json +++ b/assets/jsons/translations/de.json @@ -833,7 +833,7 @@ "specificities": "Allgemein", "requirements": "Anforderungen", "exclude": "Ausschließen", - "leaderboard": "leaderboard" + "leaderboard": "Rangliste" }, "map-types": { "accuracy": "Präzision", @@ -890,8 +890,8 @@ "fullSpread": "Full Spread" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "Alle", + "Ranked": "Eingestuft", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/es.json b/assets/jsons/translations/es.json index 908aa321..520bc53a 100644 --- a/assets/jsons/translations/es.json +++ b/assets/jsons/translations/es.json @@ -833,7 +833,7 @@ "specificities": "general", "requirements": "requisitos", "exclude": "excluir", - "leaderboard": "leaderboard" + "leaderboard": "tabla de clasificación" }, "map-types": { "accuracy": "precisión", @@ -890,8 +890,8 @@ "fullSpread": "panel completo" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "Todos", + "Ranked": "Clasificado", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/fr.json b/assets/jsons/translations/fr.json index 1f7b7103..bc266bf7 100644 --- a/assets/jsons/translations/fr.json +++ b/assets/jsons/translations/fr.json @@ -834,7 +834,7 @@ "specificities": "général", "requirements": "requis", "exclude": "exclure", - "leaderboard": "leaderboard" + "leaderboard": "tableau des leaders" }, "map-types": { "accuracy": "précision", @@ -891,8 +891,8 @@ "fullSpread": "panel complet" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "Tout", + "Ranked": "Classé", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/ja.json b/assets/jsons/translations/ja.json index b1209ad2..49d411c3 100644 --- a/assets/jsons/translations/ja.json +++ b/assets/jsons/translations/ja.json @@ -833,7 +833,7 @@ "specificities": "一般", "requirements": "要Mod", "exclude": "除外する", - "leaderboard": "leaderboard" + "leaderboard": "ランキング" }, "map-types": { "accuracy": "正確", @@ -890,8 +890,8 @@ "fullSpread": "フルスプレッド" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "すべて", + "Ranked": "ランク付けされた", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/ru.json b/assets/jsons/translations/ru.json index be1bcba6..f7971553 100644 --- a/assets/jsons/translations/ru.json +++ b/assets/jsons/translations/ru.json @@ -832,7 +832,7 @@ "specificities": "основное", "requirements": "требуемые моды", "exclude": "исключить", - "leaderboard": "leaderboard" + "leaderboard": "Таблица лидеров" }, "map-types": { "accuracy": "точность", @@ -889,8 +889,8 @@ "fullSpread": "полный набор" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "все", + "Ranked": "ранжированный", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/zh-tw.json b/assets/jsons/translations/zh-tw.json index 37aaeace..ff99b15d 100644 --- a/assets/jsons/translations/zh-tw.json +++ b/assets/jsons/translations/zh-tw.json @@ -833,7 +833,7 @@ "specificities": "general", "requirements": "要求", "exclude": "排除", - "leaderboard": "leaderboard" + "leaderboard": "排行榜" }, "map-types": { "accuracy": "精確度", @@ -890,8 +890,8 @@ "fullSpread": "Full spread" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "所有", + "Ranked": "排名的", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/zh.json b/assets/jsons/translations/zh.json index b7f2624d..d50d101d 100644 --- a/assets/jsons/translations/zh.json +++ b/assets/jsons/translations/zh.json @@ -833,7 +833,7 @@ "specificities": "general", "requirements": "要求", "exclude": "排除", - "leaderboard": "leaderboard" + "leaderboard": "排行榜" }, "map-types": { "accuracy": "精确度", @@ -890,8 +890,8 @@ "fullSpread": "full spread" }, "map-leaderboard": { - "All": "All", - "Ranked": "Ranked", + "All": "所有", + "Ranked": "排名的", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, From 825d07fac03417dc2fa9e2b3b7613fc8d271993f Mon Sep 17 00:00:00 2001 From: silentrald Date: Sat, 19 Oct 2024 05:48:36 +0800 Subject: [PATCH 3/5] [bugfix-623] removed maps.map-specificities.ranked and used maps.map-leaderboard.Ranked --- assets/jsons/translations/de.json | 3 +-- assets/jsons/translations/en.json | 1 - assets/jsons/translations/es.json | 3 +-- assets/jsons/translations/fr.json | 3 +-- assets/jsons/translations/ja.json | 3 +-- assets/jsons/translations/ru.json | 3 +-- assets/jsons/translations/zh-tw.json | 1 - assets/jsons/translations/zh.json | 1 - .../maps-playlists-panel/maps/map-item.component.tsx | 4 ++-- 9 files changed, 7 insertions(+), 15 deletions(-) diff --git a/assets/jsons/translations/de.json b/assets/jsons/translations/de.json index f9b7cd5e..dbe46e6e 100644 --- a/assets/jsons/translations/de.json +++ b/assets/jsons/translations/de.json @@ -884,14 +884,13 @@ }, "map-specificities": { "automapper": "KI", - "ranked": "Ranked", "curated": "Curated", "verified": "Verifiziert", "fullSpread": "Full Spread" }, "map-leaderboard": { "All": "Alle", - "Ranked": "Eingestuft", + "Ranked": "Ranked", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/en.json b/assets/jsons/translations/en.json index c9b679a5..49c45a93 100644 --- a/assets/jsons/translations/en.json +++ b/assets/jsons/translations/en.json @@ -891,7 +891,6 @@ }, "map-specificities": { "automapper": "AI", - "ranked": "ranked", "curated": "curated", "verified": "verified", "fullSpread": "full spread" diff --git a/assets/jsons/translations/es.json b/assets/jsons/translations/es.json index 520bc53a..4dbb5700 100644 --- a/assets/jsons/translations/es.json +++ b/assets/jsons/translations/es.json @@ -884,14 +884,13 @@ }, "map-specificities": { "automapper": "IA", - "ranked": "rankado", "curated": "recomendado", "verified": "verificado", "fullSpread": "panel completo" }, "map-leaderboard": { "All": "Todos", - "Ranked": "Clasificado", + "Ranked": "Rankado", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/fr.json b/assets/jsons/translations/fr.json index bc266bf7..f564bbf3 100644 --- a/assets/jsons/translations/fr.json +++ b/assets/jsons/translations/fr.json @@ -885,14 +885,13 @@ }, "map-specificities": { "automapper": "IA", - "ranked": "classée", "curated": "recommandée", "verified": "vérifiée", "fullSpread": "panel complet" }, "map-leaderboard": { "All": "Tout", - "Ranked": "Classé", + "Ranked": "Classée", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/ja.json b/assets/jsons/translations/ja.json index 49d411c3..fb960613 100644 --- a/assets/jsons/translations/ja.json +++ b/assets/jsons/translations/ja.json @@ -884,14 +884,13 @@ }, "map-specificities": { "automapper": "AI", - "ranked": "ランク入賞", "curated": "厳選済み", "verified": "認証済み", "fullSpread": "フルスプレッド" }, "map-leaderboard": { "All": "すべて", - "Ranked": "ランク付けされた", + "Ranked": "ランク入賞", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/ru.json b/assets/jsons/translations/ru.json index f7971553..db3ffe34 100644 --- a/assets/jsons/translations/ru.json +++ b/assets/jsons/translations/ru.json @@ -883,14 +883,13 @@ }, "map-specificities": { "automapper": "ИИ", - "ranked": "с рейтингом", "curated": "оценённые куратором", "verified": "проверенные авторы", "fullSpread": "полный набор" }, "map-leaderboard": { "All": "все", - "Ranked": "ранжированный", + "Ranked": "с рейтингом", "BeatLeader": "BeatLeader", "ScoreSaber": "ScoreSaber" }, diff --git a/assets/jsons/translations/zh-tw.json b/assets/jsons/translations/zh-tw.json index ff99b15d..0f79f14f 100644 --- a/assets/jsons/translations/zh-tw.json +++ b/assets/jsons/translations/zh-tw.json @@ -884,7 +884,6 @@ }, "map-specificities": { "automapper": "AI", - "ranked": "Ranked", "curated": "Curated", "verified": "Verified", "fullSpread": "Full spread" diff --git a/assets/jsons/translations/zh.json b/assets/jsons/translations/zh.json index d50d101d..7a2f2849 100644 --- a/assets/jsons/translations/zh.json +++ b/assets/jsons/translations/zh.json @@ -884,7 +884,6 @@ }, "map-specificities": { "automapper": "AI", - "ranked": "ranked", "curated": "curated", "verified": "verified", "fullSpread": "full spread" diff --git a/src/renderer/components/maps-playlists-panel/maps/map-item.component.tsx b/src/renderer/components/maps-playlists-panel/maps/map-item.component.tsx index d5cecbf8..6f343b8b 100644 --- a/src/renderer/components/maps-playlists-panel/maps/map-item.component.tsx +++ b/src/renderer/components/maps-playlists-panel/maps/map-item.component.tsx @@ -324,12 +324,12 @@ export function MapItemComponent ({ hash, title, autor, songAutor, {ranked && (
- {t("maps.map-specificities.ranked")} + {t("maps.map-leaderboard.Ranked")}
)} {blRanked && (
- {t("maps.map-specificities.ranked")} + {t("maps.map-leaderboard.Ranked")}
)}
{renderDiffPreview()}
From 1aadf353cad8440e6400126154ea0f1aff2a8e99 Mon Sep 17 00:00:00 2001 From: silentrald Date: Mon, 21 Oct 2024 23:55:26 +0800 Subject: [PATCH 4/5] [bugfix-623] retain options and fixed local map filtering --- .../maps/filter-panel.component.tsx | 27 ++++++++++++++----- src/shared/models/maps/beat-saver.model.ts | 2 +- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx index 1917de54..7dc603a3 100644 --- a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx +++ b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx @@ -191,7 +191,7 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat

{t("maps.map-filter-panel.leaderboard")}

@@ -306,10 +306,23 @@ function isFitAutomapper(filter: MapFilter, automapper: boolean): boolean { return automapper; } +function isFitLeaderboard(filter: MapFilter, ranked: boolean, blRanked: boolean): boolean { + switch (filter?.leaderboard) { + case MapLeaderboard.All: + return true; -function isFitRanked(filter: MapFilter, ranked: boolean): boolean { - if (!filter?.ranked) { return true; } - return ranked; + case MapLeaderboard.Ranked: + return ranked || blRanked; + + case MapLeaderboard.ScoreSaber: + return ranked; + + case MapLeaderboard.BeatLeader: + return blRanked; + + default: // filter is undefined + return true; + } } function isFitCurated(filter: MapFilter, curated: boolean): boolean { @@ -341,7 +354,7 @@ export const isLocalMapFitMapFilter = ({filter, map, search}: { filter: MapFilte if (!isFitChroma(filter, map.songDetails?.difficulties.some(diff => !!diff.chroma))) { return false; } if (!isFitFullSpread(filter, map.songDetails?.difficulties.length)) { return false; } if (!isFitAutomapper(filter, map.songDetails?.automapper)){ return false; } - if (!isFitRanked(filter, map.songDetails?.ranked || map.songDetails?.blRanked)) { return false; } + if (!isFitLeaderboard(filter, map.songDetails?.ranked, map.songDetails?.blRanked)) { return false; } if (!isFitCurated(filter, map.songDetails?.curated)) { return false; } if (!isFitVerified(filter, map.songDetails?.uploader.verified)) { return false; } if (!isFitSearch(search, {songName: map.mapInfo?.songName, songAuthorName: map.mapInfo?.songAuthorName, levelMappers: map.mapInfo?.levelMappers})) { return false; } @@ -362,7 +375,7 @@ export const isBsvMapFitMapFilter = ({filter, map, search}: { filter: MapFilter, if (!isFitChroma(filter, map.versions?.at(0)?.diffs.some(diff => !!diff.chroma))) { return false; } if (!isFitFullSpread(filter, map.versions?.at(0)?.diffs.length)) { return false; } if (!isFitAutomapper(filter, map.automapper)){ return false; } - if (!isFitRanked(filter, map.ranked || map.blRanked)) { return false; } + if (!isFitLeaderboard(filter, map.ranked, map.blRanked)) { return false; } if (!isFitCurated(filter, !!map.curator)) { return false; } if (!isFitVerified(filter, !!map.curatedAt)) { return false; } if (!isFitSearch(search, {songName: map.name, songAuthorName: map.metadata.songAuthorName, levelMappers: [map.metadata.levelAuthorName]})) { return false; } @@ -382,7 +395,7 @@ export const isSongDetailsFitMapFilter = ({filter, map, search}: { filter: MapFi if (!isFitChroma(filter, map.difficulties.some(diff => !!diff.chroma))) { return false; } if (!isFitFullSpread(filter, map.difficulties.length)) { return false; } if (!isFitAutomapper(filter, map.automapper)){ return false; } - if (!isFitRanked(filter, map.ranked || map.blRanked)) { return false; } + if (!isFitLeaderboard(filter, map.ranked, map.blRanked)) { return false; } if (!isFitCurated(filter, map.curated)) { return false; } if (!isFitVerified(filter, map.uploader.verified)) { return false; } if (!isFitSearch(search, {songName: map.name, songAuthorName: map.uploader.name, levelMappers: [map.uploader.name]})) { return false; } diff --git a/src/shared/models/maps/beat-saver.model.ts b/src/shared/models/maps/beat-saver.model.ts index 5f1f2322..dc0ed9e7 100644 --- a/src/shared/models/maps/beat-saver.model.ts +++ b/src/shared/models/maps/beat-saver.model.ts @@ -240,7 +240,7 @@ export interface MapFilter { from?: number; to?: number; fullSpread?: boolean; - leaderboard?: string; + leaderboard?: MapLeaderboard; installed?: boolean; minDuration?: number; maxDuration?: number; From e9594e79925db4ccbc1789df1cae137e17604975 Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Fri, 27 Dec 2024 21:01:45 +0100 Subject: [PATCH 5/5] little style adjustment --- .../maps-playlists-panel/maps/filter-panel.component.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx index 7dc603a3..a86f1098 100644 --- a/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx +++ b/src/renderer/components/maps-playlists-panel/maps/filter-panel.component.tsx @@ -190,6 +190,7 @@ export function FilterPanel({ className, ref, playlist = false, filter, localDat

{t("maps.map-filter-panel.leaderboard")}