Fix error handling in AutoUpdaterService and add error logging in SettingsPage

This commit is contained in:
shidorien
2024-06-02 19:16:39 +02:00
parent 5cf80ec6f2
commit 9ffa0db43e
3 changed files with 6 additions and 3 deletions
@@ -41,6 +41,7 @@ import { OculusIcon } from "renderer/components/svgs/icons/oculus-icon.component
import { BsDownloaderService } from "renderer/services/bs-version-download/bs-downloader.service";
import { AutoUpdaterService } from "renderer/services/auto-updater.service";
import BeatWaitingImg from "../../../assets/images/apngs/beat-waiting.png";
import { logRenderError } from "renderer";
export function SettingsPage() {
@@ -145,7 +146,8 @@ export function SettingsPage() {
.then(() => {
setIsChangelogAvailable(() => true);
})
.catch(() => {
.catch(Err => {
logRenderError(Err.message);
setIsChangelogAvailable(() => false);
})
.finally(() => { isChangelogResolved = true; });
@@ -104,7 +104,7 @@ export class AutoUpdaterService {
}
public async showChangelog(version:string): Promise<void>{
const changelog = await this.getChangelogVersion(version);
const changelog = await this.getChangelogVersion(version)
this.modal.openModal(ChangelogModal, changelog);
}
+2 -1
View File
@@ -24,6 +24,7 @@ import { OsDiagnosticService } from "renderer/services/os-diagnostic.service";
import { useService } from "renderer/hooks/use-service.hook";
import { AutoUpdaterService } from "renderer/services/auto-updater.service";
import { gt, parse } from "semver"
import { logRenderError } from "renderer";
export default function App() {
useService(OsDiagnosticService);
@@ -50,7 +51,7 @@ export default function App() {
autoUpdater.setLastAppVersion(appVersion);
if (parse(lastAppVersion) && gt(appVersion, lastAppVersion)) {
autoUpdater.showChangelog(appVersion);
await autoUpdater.showChangelog(appVersion).catch(Err => logRenderError(Err.message));
}
};