feat(signal): ADR-134 CSI→CIR via ISTA + NeumannSolver warm-start (#837)

* feat(signal): ADR-134 — CSI→CIR via ISTA + NeumannSolver warm-start

End-to-end first-class Channel Impulse Response estimation in the Rust
workspace. Bridges CSI (frequency domain) to CIR (delay domain) so
multistatic coherence gating, NLOS/LOS classification, and (at HT40+)
ToF ranging become tractable in `wifi-densepose-signal`.

Algorithm: ISTA L1 sparse recovery over a normalized DFT sub-matrix
sensing operator Φ ∈ ℂ^(K×G) with G = 3K (3× super-resolution). The
Tikhonov-regularised warm start re-uses `ruvector_solver::neumann::
NeumannSolver` — same call pattern as `fresnel.rs:280` and
`train/subcarrier.rs:225` — so no new crate dependencies.

Tiers supported: HT20 / HT40 / HE20 (Tier A-HE, C6) / HE40. The C6
HE-LTF tier is the preferred Tier A target whenever an 11ax AP is in
range; firmware substrate already shipped at v0.7.0-esp32 per ADR-110.

Measured performance (release, single CirEstimator shared across 12
links): HT20 2.72 ms / HE20 3.20 ms / HT40 13.43 ms / HE40 9.71 ms per
estimate(). HT20 12-link multistatic 17.7 ms — fits the 50 ms RuvSense
cycle; HT40 12-link 74 ms exceeds it and is flagged in ADR-134 §2.7 as
requiring Rayon parallelism or G=2K super-res reduction.

Measured Φ conditioning: κ(Φ) ≈ 1.00 identically across all tiers.
ADR-134 §2.3 was corrected — the C6 advantage is statistical SNR gain
(√(242/52) ≈ 2.16×) from more independent measurements, not improved
conditioning.

Witness: bit-deterministic SHA-256 over CirEstimator output on the
synthetic ADR-028 reference signal (100 frames, top-5 taps, 1e-6
quantization). Hash committed to expected_cir_features.sha256;
verify-cir-proof.sh wires the check into the existing witness bundle.

CI: cargo test --features cir + verify-cir-proof.sh added as separate
steps under the Rust Workspace Tests job; regressions are unambiguously
attributable.

Files:
- ADR + WITNESS-LOG-028 row 34 + CLAUDE.md module count (14 → 15)
- src/ruvsense/cir.rs (~540 LOC) + lib.rs re-exports + multistatic.rs
  wire-up (reversible via `use_cir_gate=false`)
- 3 integration tests + Criterion bench + 3 deterministic fixtures
- cir_proof_runner binary + sha256 + verify-cir-proof.sh

Test rate: 395 pass / 6 ignored (P2 ISTA hyperparameter tuning; see
#[ignore] reasons) / 0 fail. cargo check clean; verify-cir-proof.sh
VERDICT: PASS.

Co-Authored-By: claude-flow <ruv@ruv.net>

* fix(signal): make CIR witness cross-platform-deterministic

The first witness (Windows-generated hash 89704bfd…) failed on Linux CI
with a different hash (b36741bf…). Root cause: hashing `re`/`im` parts of
top-5 taps at 1e-6 precision is too tight against libm differences in
sin/cos/sqrt across glibc, MSVC, and Apple-clang. The previous
"top-5 sorted by magnitude" form also suffered from rank instability when
taps are near-tied — libm jitter could shuffle the ordering even when the
algorithm is unchanged.

New canonical form: full per-tap quantised-magnitude profile in natural
index order, no sort.

  - 156 taps × 2 bytes (u16 le) per frame = 312 bytes/frame.
  - Quantisation 1e-2 — robust to ~1e-3 float drift while still tripping
    on real algorithmic changes (e.g., a 10× lambda shift moves magnitudes
    by >1e-2).
  - No top-K selection — eliminates the unstable magnitude-sort step.

Regenerated expected_cir_features.sha256 — new hash 120bd7b1…

If the next CI run still mismatches, the cause is structural (rustfft SIMD
code path selection or NeumannSolver internal ordering), not magnitudes,
and the witness needs further coarsening or to be made platform-tagged.

Co-Authored-By: claude-flow <ruv@ruv.net>
This commit is contained in:
rUv
2026-05-28 16:24:37 -04:00
committed by GitHub
parent 04f205a05e
commit 9e7fa83210
23 changed files with 5024 additions and 6 deletions
+130
View File
@@ -0,0 +1,130 @@
#!/usr/bin/env python3
"""
CIR Verification Helper (ADR-134)
Optional Python comparator — invokes the Rust cir_proof_runner binary and
checks its output against expected_cir_features.sha256.
Usage:
python cir_verify_helper.py # verify against stored hash
python cir_verify_helper.py --generate # regenerate hash via Rust binary
This script is a thin wrapper; all cryptographic work is done in the Rust
binary. It exists to integrate the CIR proof step into the Python verify.py
flow if needed.
"""
import argparse
import os
import subprocess
import sys
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
REPO_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, "..", "..", "..", ".."))
def find_binary() -> str:
"""Locate the cir_proof_runner binary."""
candidates = [
os.path.join(REPO_ROOT, "v2", "target", "release", "cir_proof_runner"),
os.path.join(REPO_ROOT, "v2", "target", "release", "cir_proof_runner.exe"),
os.path.join(REPO_ROOT, "v2", "target", "debug", "cir_proof_runner"),
os.path.join(REPO_ROOT, "v2", "target", "debug", "cir_proof_runner.exe"),
]
for path in candidates:
if os.path.isfile(path):
return path
return ""
def build_binary() -> bool:
"""Build the release binary via cargo."""
print("Building cir_proof_runner (release)...")
result = subprocess.run(
[
"cargo", "build",
"-p", "wifi-densepose-signal",
"--bin", "cir_proof_runner",
"--release",
"--no-default-features",
],
cwd=os.path.join(REPO_ROOT, "v2"),
capture_output=True,
text=True,
)
if result.returncode != 0:
print("Build failed:", result.stderr[-2000:])
return False
return True
def run_generate(binary: str) -> str:
"""Run the binary with --generate-hash; return the hex hash."""
result = subprocess.run(
[binary, "--generate-hash"],
cwd=REPO_ROOT,
capture_output=True,
text=True,
)
if result.returncode != 0:
print("Error running binary:", result.stderr)
return ""
return result.stdout.strip()
def run_verify(binary: str) -> bool:
"""Run the binary in verify mode; return True on PASS."""
result = subprocess.run(
[binary],
cwd=REPO_ROOT,
capture_output=True,
text=True,
)
print(result.stdout.strip())
if result.stderr.strip():
print(result.stderr.strip(), file=sys.stderr)
return result.returncode == 0
def main() -> None:
parser = argparse.ArgumentParser(description="CIR verification helper (ADR-134)")
parser.add_argument(
"--generate",
action="store_true",
help="Regenerate expected_cir_features.sha256 via Rust binary",
)
parser.add_argument(
"--build",
action="store_true",
default=False,
help="Build the binary before running (default: use cached binary)",
)
args = parser.parse_args()
binary = find_binary()
if args.build or not binary:
if not build_binary():
sys.exit(1)
binary = find_binary()
if not binary:
print("ERROR: cir_proof_runner binary not found. Run with --build.")
sys.exit(1)
if args.generate:
hash_val = run_generate(binary)
if not hash_val:
sys.exit(1)
hash_file = os.path.join(SCRIPT_DIR, "expected_cir_features.sha256")
with open(hash_file, "w") as f:
f.write(hash_val + "\n")
print(f"Wrote CIR hash to {hash_file}")
print(f"Hash: {hash_val}")
else:
ok = run_verify(binary)
sys.exit(0 if ok else 1)
if __name__ == "__main__":
main()
@@ -0,0 +1 @@
120bd7b1f549f57f3773971a389c48c2bdd99b4ab1f205935867a16e95583995