From 9679b220720673e22a11efa992edf71cee5116ec Mon Sep 17 00:00:00 2001
From: Hocuri <hocuri@gmx.de>
Date: Tue, 5 Nov 2024 15:28:50 +0100
Subject: [PATCH] fix: Accept the deprecated 3 as an alias for 2 (#3410)

---
 .../thoughtcrime/securesms/RegistrationActivity.java   | 10 ++++++----
 src/main/res/layout/registration_activity.xml          |  1 -
 src/main/res/values/arrays.xml                         |  6 ------
 3 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/main/java/org/thoughtcrime/securesms/RegistrationActivity.java b/src/main/java/org/thoughtcrime/securesms/RegistrationActivity.java
index f52eafffb..c76dd57ad 100644
--- a/src/main/java/org/thoughtcrime/securesms/RegistrationActivity.java
+++ b/src/main/java/org/thoughtcrime/securesms/RegistrationActivity.java
@@ -31,7 +31,6 @@ import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
 import android.view.View;
-import android.widget.CheckBox;
 import android.widget.ImageView;
 import android.widget.Spinner;
 import android.widget.TextView;
@@ -225,9 +224,12 @@ public class RegistrationActivity extends BaseActionBarActivity implements DcEve
             authMethod.setSelection(sel);
             expandAdvanced = expandAdvanced || sel != 0;
 
-            int certCheckFlags = DcHelper.getInt(this, "imap_certificate_checks");
-            certCheck.setSelection(certCheckFlags);
-            expandAdvanced = expandAdvanced || certCheckFlags != 0;
+            int imapCertificateChecks = DcHelper.getInt(this, "imap_certificate_checks");
+            if (imapCertificateChecks == 3) {
+              imapCertificateChecks = 2; // 3 is a deprecated alias for 2
+            }
+            certCheck.setSelection(imapCertificateChecks);
+            expandAdvanced = expandAdvanced || imapCertificateChecks != 0;
         } else if (getIntent() != null && getIntent().getBundleExtra(ACCOUNT_DATA) != null) {
           // Companion app might have sent account data
           Bundle b = getIntent().getBundleExtra(ACCOUNT_DATA);
diff --git a/src/main/res/layout/registration_activity.xml b/src/main/res/layout/registration_activity.xml
index 0a8007c83..e6047c32e 100644
--- a/src/main/res/layout/registration_activity.xml
+++ b/src/main/res/layout/registration_activity.xml
@@ -384,7 +384,6 @@
             android:layout_width="0dp"
             android:layout_height="48dp"
             android:entries="@array/pref_dc_certck_entries"
-            android:entryValues="@array/pref_dc_certck_values"
             app:layout_constraintEnd_toEndOf="@id/guideline_root_end"
             app:layout_constraintStart_toStartOf="@id/guideline_root_start"
             app:layout_constraintTop_toBottomOf="@id/cert_check_label" />
diff --git a/src/main/res/values/arrays.xml b/src/main/res/values/arrays.xml
index 645058fc7..988725912 100644
--- a/src/main/res/values/arrays.xml
+++ b/src/main/res/values/arrays.xml
@@ -158,12 +158,6 @@
         <item>@string/accept_invalid_certificates</item>
     </string-array>
 
-    <string-array name="pref_dc_certck_values">
-        <item>0</item>
-        <item>1</item>
-        <item>3</item>
-    </string-array>
-
   <!-- discrete MIME type (the part before the "/") -->