From 83e9860aa90f42ffdd4cd04520faddbdbe3aa056 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Sat, 22 Aug 2020 00:44:45 +0200 Subject: [PATCH] fix PermanentDenialDialog for save-attachment (query by activity, not by fragment), remove toasts that do not contain useful information that are not shown before --- src/org/thoughtcrime/securesms/ConversationFragment.java | 3 +-- src/org/thoughtcrime/securesms/MediaPreviewActivity.java | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ConversationFragment.java b/src/org/thoughtcrime/securesms/ConversationFragment.java index 81b39d55e..83a181581 100644 --- a/src/org/thoughtcrime/securesms/ConversationFragment.java +++ b/src/org/thoughtcrime/securesms/ConversationFragment.java @@ -444,11 +444,10 @@ public class ConversationFragment extends Fragment private void handleSaveAttachment(final DcMsg message) { SaveAttachmentTask.showWarningDialog(getContext(), (dialogInterface, i) -> { - Permissions.with(this) + Permissions.with(getActivity()) .request(Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE) .ifNecessary() .withPermanentDenialDialog(getString(R.string.perm_explain_access_to_storage_denied)) - .onAnyDenied(() -> Toast.makeText(getContext(), R.string.perm_explain_access_to_storage_denied, Toast.LENGTH_LONG).show()) .onAllGranted(() -> { SaveAttachmentTask saveTask = new SaveAttachmentTask(getContext()); SaveAttachmentTask.Attachment attachment = new SaveAttachmentTask.Attachment( diff --git a/src/org/thoughtcrime/securesms/MediaPreviewActivity.java b/src/org/thoughtcrime/securesms/MediaPreviewActivity.java index b183869a3..544089c77 100644 --- a/src/org/thoughtcrime/securesms/MediaPreviewActivity.java +++ b/src/org/thoughtcrime/securesms/MediaPreviewActivity.java @@ -305,7 +305,6 @@ public class MediaPreviewActivity extends PassphraseRequiredActionBarActivity .request(Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE) .ifNecessary() .withPermanentDenialDialog(getString(R.string.perm_explain_access_to_storage_denied)) - .onAnyDenied(() -> Toast.makeText(this, R.string.perm_explain_access_to_storage_denied, Toast.LENGTH_LONG).show()) .onAllGranted(() -> { SaveAttachmentTask saveTask = new SaveAttachmentTask(MediaPreviewActivity.this); long saveDate = (mediaItem.date > 0) ? mediaItem.date : System.currentTimeMillis();